Updating the Clojurescript Checker

Discussion:

Vincent Heuken

2015-11-29 21:55:47 UTC

I recently made an issue on the typed clojurescript sample project's github
<https://github.com/frenchy64/typed-clojurescript-play/issues/1> regarding
core.typed not working on the latest version of Clojurescript. You
mentioned you had a list of things to get it working again. I'd love to try
and help get it working again.

Ambrose Bonnaire-Sergeant

2015-11-29 22:53:26 UTC

Permalink

Hi Vincent,

Awesome!

This issue <http://dev.clojure.org/jira/browse/CLJS-1461> needs to be
resolved.

Here's what to do.

1. Look over the tools.analyzer.js AST format
<http://clojure.github.io/tools.analyzer.js/spec/quickref.html>
2. Notice how the implementation of tools.analyzer.js conforms to this spec.
eg. case*
<https://github.com/clojure/tools.analyzer.js/blob/eec5e3dd3fbeb306511aa8cdbeb663bac94392f9/src/main/clojure/clojure/tools/analyzer/js.clj#L290-L325>,
or delegates to tools.analyzer, eg. try
<https://github.com/clojure/tools.analyzer/blob/f5d959f4e9e12a0a9d3d74293d9ff2ca0ad65ad4/src/main/clojure/clojure/tools/analyzer.clj#L373-L404>
3. Compare this spec to the actual ClojureScript analyzer.
eg. try
<https://github.com/clojure/clojurescript/blob/master/src/main/clojure/cljs/analyzer.cljc#L1000-L1059>
4. Note any differences between the specs.
eg. :catch in ClojureScript
<https://github.com/clojure/clojurescript/blob/3e1af212e114a9968c6f69719b0346df12bd6d0e/src/main/clojure/cljs/analyzer.cljc#L1058>
:try
node, vs :catches vector in tools.analyzer
<https://github.com/clojure/tools.analyzer/blob/1c8693b30e8459ad3fbdb21871164ba82afb7b43/src/main/clojure/clojure/tools/analyzer.clj#L400>
:try node.
5. Prepare a patch for the ClojureScript analyzer that updates the AST to
conform to tools.analyzer.

I'm available to video chat over the week if that helps.

Thanks,
Ambrose

Post by Vincent Heuken
I recently made an issue on the typed clojurescript sample project's
github <https://github.com/frenchy64/typed-clojurescript-play/issues/1> regarding
core.typed not working on the latest version of Clojurescript. You
mentioned you had a list of things to get it working again. I'd love to try
and help get it working again.

Vincent Heuken

2015-11-30 08:05:33 UTC

Permalink

Thanks for getting back to me.

I won't have time to start for a couple of days, but I wanted to go in and
try something simple to make sure I have the right idea, so I tried my hand
at throw
<http://clojure.github.io/tools.analyzer.js/spec/quickref.html#throw>. The
diff is below. Let me know if this is right or of I'm way off.

---
diff --git a/src/main/clojure/cljs/analyzer.cljc
b/src/main/clojure/cljs/analyzer.cljc
index 437c8a0..6eb5b6b 100644
--- a/src/main/clojure/cljs/analyzer.cljc
+++ b/src/main/clojure/cljs/analyzer.cljc
@@ -994,8 +994,8 @@
[op env [_ throw :as form] name _]
(let [throw-expr (disallowing-recur (analyze (assoc env :context :expr)
throw))]
{:env env :op :throw :form form
- :throw throw-expr
- :children [throw-expr]}))
+ :exception throw-expr
+ :children [:exception]}))

(defmethod parse 'try
[op env [_ & body :as form] name _]

On Sunday, November 29, 2015 at 2:53:46 PM UTC-8, Ambrose Bonnaire-Sergeant

Post by Ambrose Bonnaire-Sergeant
Hi Vincent,
Awesome!
This issue <http://dev.clojure.org/jira/browse/CLJS-1461> needs to be
resolved.
Here's what to do.
1. Look over the tools.analyzer.js AST format
<http://clojure.github.io/tools.analyzer.js/spec/quickref.html>
2. Notice how the implementation of tools.analyzer.js conforms to this spec.
eg. case*
<https://github.com/clojure/tools.analyzer.js/blob/eec5e3dd3fbeb306511aa8cdbeb663bac94392f9/src/main/clojure/clojure/tools/analyzer/js.clj#L290-L325>,
or delegates to tools.analyzer, eg. try
<https://github.com/clojure/tools.analyzer/blob/f5d959f4e9e12a0a9d3d74293d9ff2ca0ad65ad4/src/main/clojure/clojure/tools/analyzer.clj#L373-L404>
3. Compare this spec to the actual ClojureScript analyzer.
eg. try
<https://github.com/clojure/clojurescript/blob/master/src/main/clojure/cljs/analyzer.cljc#L1000-L1059>
4. Note any differences between the specs.
eg. :catch in ClojureScript
<https://github.com/clojure/clojurescript/blob/3e1af212e114a9968c6f69719b0346df12bd6d0e/src/main/clojure/cljs/analyzer.cljc#L1058> :try
node, vs :catches vector in tools.analyzer
<https://github.com/clojure/tools.analyzer/blob/1c8693b30e8459ad3fbdb21871164ba82afb7b43/src/main/clojure/clojure/tools/analyzer.clj#L400>
:try node.
5. Prepare a patch for the ClojureScript analyzer that updates the AST to
conform to tools.analyzer.
I'm available to video chat over the week if that helps.
Thanks,
Ambrose

Vincent Heuken

2015-11-30 08:06:27 UTC

Permalink

Ambrose Bonnaire-Sergeant

2015-11-30 08:15:29 UTC

Permalink

Yes, that's a good start. You should also start thinking about how this
affects the rest of the analyzer/compiler. eg. :throw is now :exception,
and :children traversal is drastically different and keep notes about that
too.

Eventually the patch will incorporate these changes, but I would leave them
until last.

Thanks,
Ambrose

Post by Vincent Heuken
Thanks for getting back to me.
I won't have time to start for a couple of days, but I wanted to go in and
try something simple to make sure I have the right idea, so I tried my hand
at throw
<http://clojure.github.io/tools.analyzer.js/spec/quickref.html#throw>. The
diff is below. Let me know if this is right or of I'm way off.
---
diff --git a/src/main/clojure/cljs/analyzer.cljc
b/src/main/clojure/cljs/analyzer.cljc
index 437c8a0..6eb5b6b 100644
--- a/src/main/clojure/cljs/analyzer.cljc
+++ b/src/main/clojure/cljs/analyzer.cljc
@@ -994,8 +994,8 @@
[op env [_ throw :as form] name _]
(let [throw-expr (disallowing-recur (analyze (assoc env :context :expr)
throw))]
{:env env :op :throw :form form
- :throw throw-expr
- :children [throw-expr]}))
+ :exception throw-expr
+ :children [:exception]}))
(defmethod parse 'try
[op env [_ & body :as form] name _]
On Sunday, November 29, 2015 at 2:53:46 PM UTC-8, Ambrose

Sean Walker

2016-01-22 16:05:59 UTC

Permalink

Has any progress been made on this? I am interested in helping get this
updated, so I'm willing to assist/collaborate if you're still working on
this, or look into it myself otherwise.

Vincent Heuken

2016-01-23 01:42:23 UTC

Permalink

Unfortunately I haven't had time. Feel free to start on it yourself if
you'd like.

Post by Sean Walker
Has any progress been made on this? I am interested in helping get this
updated, so I'm willing to assist/collaborate if you're still working on
this, or look into it myself otherwise.

Post by Vincent Heuken
Thanks for getting back to me.
I won't have time to start for a couple of days, but I wanted to go in
and try something simple to make sure I have the right idea, so I tried my
hand at throw
<http://clojure.github.io/tools.analyzer.js/spec/quickref.html#throw>. The
diff is below. Let me know if this is right or of I'm way off.
---
diff --git a/src/main/clojure/cljs/analyzer.cljc
b/src/main/clojure/cljs/analyzer.cljc
index 437c8a0..6eb5b6b 100644
--- a/src/main/clojure/cljs/analyzer.cljc
+++ b/src/main/clojure/cljs/analyzer.cljc
@@ -994,8 +994,8 @@
[op env [_ throw :as form] name _]
(let [throw-expr (disallowing-recur (analyze (assoc env :context
:expr) throw))]
{:env env :op :throw :form form
- :throw throw-expr
- :children [throw-expr]}))
+ :exception throw-expr
+ :children [:exception]}))
(defmethod parse 'try
[op env [_ & body :as form] name _]
On Sunday, November 29, 2015 at 2:53:46 PM UTC-8, Ambrose

Post by Ambrose Bonnaire-Sergeant
Hi Vincent,
Awesome!
This issue <http://dev.clojure.org/jira/browse/CLJS-1461> needs to be
resolved.
Here's what to do.
1. Look over the tools.analyzer.js AST format
<http://clojure.github.io/tools.analyzer.js/spec/quickref.html>
2. Notice how the implementation of tools.analyzer.js conforms to this spec.
eg. case*
<https://github.com/clojure/tools.analyzer.js/blob/eec5e3dd3fbeb306511aa8cdbeb663bac94392f9/src/main/clojure/clojure/tools/analyzer/js.clj#L290-L325>,
or delegates to tools.analyzer, eg. try
<https://github.com/clojure/tools.analyzer/blob/f5d959f4e9e12a0a9d3d74293d9ff2ca0ad65ad4/src/main/clojure/clojure/tools/analyzer.clj#L373-L404>
3. Compare this spec to the actual ClojureScript analyzer.
eg. try
<https://github.com/clojure/clojurescript/blob/master/src/main/clojure/cljs/analyzer.cljc#L1000-L1059>
4. Note any differences between the specs.
eg. :catch in ClojureScript
<https://github.com/clojure/clojurescript/blob/3e1af212e114a9968c6f69719b0346df12bd6d0e/src/main/clojure/cljs/analyzer.cljc#L1058> :try
node, vs :catches vector in tools.analyzer
<https://github.com/clojure/tools.analyzer/blob/1c8693b30e8459ad3fbdb21871164ba82afb7b43/src/main/clojure/clojure/tools/analyzer.clj#L400>
:try node.
5. Prepare a patch for the ClojureScript analyzer that updates the AST
to conform to tools.analyzer.
I'm available to video chat over the week if that helps.
Thanks,
Ambrose

--
Vincent Heuken

Ambrose Bonnaire-Sergeant

2016-01-24 01:30:56 UTC

Permalink

No progress from me either.

Sean, the instructions earlier in the thread should still be a good
starting point to work on.

Thanks,
Ambrose

Post by Vincent Heuken
Unfortunately I haven't had time. Feel free to start on it yourself if
you'd like.

Post by Vincent Heuken
Thanks for getting back to me.
I won't have time to start for a couple of days, but I wanted to go in
and try something simple to make sure I have the right idea, so I tried my
hand at throw
<http://clojure.github.io/tools.analyzer.js/spec/quickref.html#throw>. The
diff is below. Let me know if this is right or of I'm way off.
---
diff --git a/src/main/clojure/cljs/analyzer.cljc
b/src/main/clojure/cljs/analyzer.cljc
index 437c8a0..6eb5b6b 100644
--- a/src/main/clojure/cljs/analyzer.cljc
+++ b/src/main/clojure/cljs/analyzer.cljc
@@ -994,8 +994,8 @@
[op env [_ throw :as form] name _]
(let [throw-expr (disallowing-recur (analyze (assoc env :context
:expr) throw))]
{:env env :op :throw :form form
- :throw throw-expr
- :children [throw-expr]}))
+ :exception throw-expr
+ :children [:exception]}))
(defmethod parse 'try
[op env [_ & body :as form] name _]
On Sunday, November 29, 2015 at 2:53:46 PM UTC-8, Ambrose

Post by Ambrose Bonnaire-Sergeant
Hi Vincent,
Awesome!
This issue <http://dev.clojure.org/jira/browse/CLJS-1461> needs to be
resolved.
Here's what to do.
1. Look over the tools.analyzer.js AST format
<http://clojure.github.io/tools.analyzer.js/spec/quickref.html>
2. Notice how the implementation of tools.analyzer.js conforms to this spec.
eg. case*
<https://github.com/clojure/tools.analyzer.js/blob/eec5e3dd3fbeb306511aa8cdbeb663bac94392f9/src/main/clojure/clojure/tools/analyzer/js.clj#L290-L325>,
or delegates to tools.analyzer, eg. try
<https://github.com/clojure/tools.analyzer/blob/f5d959f4e9e12a0a9d3d74293d9ff2ca0ad65ad4/src/main/clojure/clojure/tools/analyzer.clj#L373-L404>
3. Compare this spec to the actual ClojureScript analyzer.
eg. try
<https://github.com/clojure/clojurescript/blob/master/src/main/clojure/cljs/analyzer.cljc#L1000-L1059>
4. Note any differences between the specs.
eg. :catch in ClojureScript
<https://github.com/clojure/clojurescript/blob/3e1af212e114a9968c6f69719b0346df12bd6d0e/src/main/clojure/cljs/analyzer.cljc#L1058> :try
node, vs :catches vector in tools.analyzer
<https://github.com/clojure/tools.analyzer/blob/1c8693b30e8459ad3fbdb21871164ba82afb7b43/src/main/clojure/clojure/tools/analyzer.clj#L400>
:try node.
5. Prepare a patch for the ClojureScript analyzer that updates the AST
to conform to tools.analyzer.
I'm available to video chat over the week if that helps.
Thanks,
Ambrose

Post by Vincent Heuken
I recently made an issue on the typed clojurescript sample project's github
<https://github.com/frenchy64/typed-clojurescript-play/issues/1> regarding
core.typed not working on the latest version of Clojurescript. You
mentioned you had a list of things to get it working again. I'd love to try
and help get it working again.

--
Vincent Heuken

Vincent Heuken

2016-01-24 02:59:12 UTC

Permalink

Sean, if you do end up starting, could you link to your Github (or
wherever)? I'd like to watch progress and possibly help out if I can.

On Sat, Jan 23, 2016 at 5:30 PM, Ambrose Bonnaire-Sergeant <

Post by Ambrose Bonnaire-Sergeant
No progress from me either.
Sean, the instructions earlier in the thread should still be a good
starting point to work on.
Thanks,
Ambrose

Post by Vincent Heuken
Unfortunately I haven't had time. Feel free to start on it yourself if
you'd like.
On Fri, Jan 22, 2016 at 8:05 AM, Sean Walker <

Post by Vincent Heuken
Thanks for getting back to me.
I won't have time to start for a couple of days, but I wanted to go in
and try something simple to make sure I have the right idea, so I tried my
hand at throw
<http://clojure.github.io/tools.analyzer.js/spec/quickref.html#throw>. The
diff is below. Let me know if this is right or of I'm way off.
---
diff --git a/src/main/clojure/cljs/analyzer.cljc
b/src/main/clojure/cljs/analyzer.cljc
index 437c8a0..6eb5b6b 100644
--- a/src/main/clojure/cljs/analyzer.cljc
+++ b/src/main/clojure/cljs/analyzer.cljc
@@ -994,8 +994,8 @@
[op env [_ throw :as form] name _]
(let [throw-expr (disallowing-recur (analyze (assoc env :context
:expr) throw))]
{:env env :op :throw :form form
- :throw throw-expr
- :children [throw-expr]}))
+ :exception throw-expr
+ :children [:exception]}))
(defmethod parse 'try
[op env [_ & body :as form] name _]
On Sunday, November 29, 2015 at 2:53:46 PM UTC-8, Ambrose

Post by Ambrose Bonnaire-Sergeant
Hi Vincent,
Awesome!
This issue <http://dev.clojure.org/jira/browse/CLJS-1461> needs to be
resolved.
Here's what to do.
1. Look over the tools.analyzer.js AST format
<http://clojure.github.io/tools.analyzer.js/spec/quickref.html>
2. Notice how the implementation of tools.analyzer.js conforms to this spec.
eg. case*
<https://github.com/clojure/tools.analyzer.js/blob/eec5e3dd3fbeb306511aa8cdbeb663bac94392f9/src/main/clojure/clojure/tools/analyzer/js.clj#L290-L325>,
or delegates to tools.analyzer, eg. try
<https://github.com/clojure/tools.analyzer/blob/f5d959f4e9e12a0a9d3d74293d9ff2ca0ad65ad4/src/main/clojure/clojure/tools/analyzer.clj#L373-L404>
3. Compare this spec to the actual ClojureScript analyzer.
eg. try
<https://github.com/clojure/clojurescript/blob/master/src/main/clojure/cljs/analyzer.cljc#L1000-L1059>
4. Note any differences between the specs.
eg. :catch in ClojureScript
<https://github.com/clojure/clojurescript/blob/3e1af212e114a9968c6f69719b0346df12bd6d0e/src/main/clojure/cljs/analyzer.cljc#L1058> :try
node, vs :catches vector in tools.analyzer
<https://github.com/clojure/tools.analyzer/blob/1c8693b30e8459ad3fbdb21871164ba82afb7b43/src/main/clojure/clojure/tools/analyzer.clj#L400>
:try node.
5. Prepare a patch for the ClojureScript analyzer that updates the AST
to conform to tools.analyzer.
I'm available to video chat over the week if that helps.
Thanks,
Ambrose

Post by Vincent Heuken
I recently made an issue on the typed clojurescript sample project's github
<https://github.com/frenchy64/typed-clojurescript-play/issues/1> regarding
core.typed not working on the latest version of Clojurescript. You
mentioned you had a list of things to get it working again. I'd love to try
and help get it working again.

--
Vincent Heuken

Sean Walker

2016-01-26 07:29:50 UTC

Permalink

Sure, my github is https://github.com/AnOctopus. I'll likely start on it
later this week, once I've cleared a few other things off of my plate.

Post by Vincent Heuken
Sean, if you do end up starting, could you link to your Github (or
wherever)? I'd like to watch progress and possibly help out if I can.
On Sat, Jan 23, 2016 at 5:30 PM, Ambrose Bonnaire-Sergeant <

Post by Ambrose Bonnaire-Sergeant
No progress from me either.
Sean, the instructions earlier in the thread should still be a good
starting point to work on.
Thanks,
Ambrose

Post by Vincent Heuken
Unfortunately I haven't had time. Feel free to start on it yourself if
you'd like.

Post by Vincent Heuken
Thanks for getting back to me.
I won't have time to start for a couple of days, but I wanted to go in
and try something simple to make sure I have the right idea, so I tried my
hand at throw
<http://clojure.github.io/tools.analyzer.js/spec/quickref.html#throw>. The
diff is below. Let me know if this is right or of I'm way off.
---
diff --git a/src/main/clojure/cljs/analyzer.cljc
b/src/main/clojure/cljs/analyzer.cljc
index 437c8a0..6eb5b6b 100644
--- a/src/main/clojure/cljs/analyzer.cljc
+++ b/src/main/clojure/cljs/analyzer.cljc
@@ -994,8 +994,8 @@
[op env [_ throw :as form] name _]
(let [throw-expr (disallowing-recur (analyze (assoc env :context
:expr) throw))]
{:env env :op :throw :form form
- :throw throw-expr
- :children [throw-expr]}))
+ :exception throw-expr
+ :children [:exception]}))
(defmethod parse 'try
[op env [_ & body :as form] name _]
On Sunday, November 29, 2015 at 2:53:46 PM UTC-8, Ambrose

Post by Ambrose Bonnaire-Sergeant
Hi Vincent,
Awesome!
This issue <http://dev.clojure.org/jira/browse/CLJS-1461> needs to
be resolved.
Here's what to do.
1. Look over the tools.analyzer.js AST format
<http://clojure.github.io/tools.analyzer.js/spec/quickref.html>
2. Notice how the implementation of tools.analyzer.js conforms to this spec.
eg. case*
<https://github.com/clojure/tools.analyzer.js/blob/eec5e3dd3fbeb306511aa8cdbeb663bac94392f9/src/main/clojure/clojure/tools/analyzer/js.clj#L290-L325>,
or delegates to tools.analyzer, eg. try
<https://github.com/clojure/tools.analyzer/blob/f5d959f4e9e12a0a9d3d74293d9ff2ca0ad65ad4/src/main/clojure/clojure/tools/analyzer.clj#L373-L404>
3. Compare this spec to the actual ClojureScript analyzer.
eg. try
<https://github.com/clojure/clojurescript/blob/master/src/main/clojure/cljs/analyzer.cljc#L1000-L1059>
4. Note any differences between the specs.
eg. :catch in ClojureScript
<https://github.com/clojure/clojurescript/blob/3e1af212e114a9968c6f69719b0346df12bd6d0e/src/main/clojure/cljs/analyzer.cljc#L1058> :try
node, vs :catches vector in tools.analyzer
<https://github.com/clojure/tools.analyzer/blob/1c8693b30e8459ad3fbdb21871164ba82afb7b43/src/main/clojure/clojure/tools/analyzer.clj#L400>
:try node.
5. Prepare a patch for the ClojureScript analyzer that updates the
AST to conform to tools.analyzer.
I'm available to video chat over the week if that helps.
Thanks,
Ambrose

Post by Vincent Heuken
I recently made an issue on the typed clojurescript sample project's github
<https://github.com/frenchy64/typed-clojurescript-play/issues/1> regarding
core.typed not working on the latest version of Clojurescript. You
mentioned you had a list of things to get it working again. I'd love to try
and help get it working again.

--
Vincent Heuken

Sean Walker

2016-01-31 01:03:19 UTC

Permalink

I have tried adjusting a few more forms to match the tools.analyzer ast,
and I want to make sure I'm on the right track as well. The commit is here
<https://github.com/AnOctopus/clojurescript/commit/07e553bd54945238c819795c4164a9f65d0ca23f>.
I'm not sure about a few things (is ctor just class, or something else?),
but I think I'm starting to understand how this part of the analyzer works.

Post by Sean Walker
Sure, my github is https://github.com/AnOctopus. I'll likely start on it
later this week, once I've cleared a few other things off of my plate.

Post by Ambrose Bonnaire-Sergeant
No progress from me either.
Sean, the instructions earlier in the thread should still be a good
starting point to work on.
Thanks,
Ambrose

Post by Vincent Heuken
Unfortunately I haven't had time. Feel free to start on it yourself if
you'd like.

Post by Sean Walker
Has any progress been made on this? I am interested in helping get
this updated, so I'm willing to assist/collaborate if you're still working
on this, or look into it myself otherwise.

Post by Vincent Heuken
Thanks for getting back to me.
I won't have time to start for a couple of days, but I wanted to go
in and try something simple to make sure I have the right idea, so I tried
my hand at throw
<http://clojure.github.io/tools.analyzer.js/spec/quickref.html#throw>. The
diff is below. Let me know if this is right or of I'm way off.
---
diff --git a/src/main/clojure/cljs/analyzer.cljc
b/src/main/clojure/cljs/analyzer.cljc
index 437c8a0..6eb5b6b 100644
--- a/src/main/clojure/cljs/analyzer.cljc
+++ b/src/main/clojure/cljs/analyzer.cljc
@@ -994,8 +994,8 @@
[op env [_ throw :as form] name _]
(let [throw-expr (disallowing-recur (analyze (assoc env :context
:expr) throw))]
{:env env :op :throw :form form
- :throw throw-expr
- :children [throw-expr]}))
+ :exception throw-expr
+ :children [:exception]}))
(defmethod parse 'try
[op env [_ & body :as form] name _]
On Sunday, November 29, 2015 at 2:53:46 PM UTC-8, Ambrose

Post by Ambrose Bonnaire-Sergeant
Hi Vincent,
Awesome!
This issue <http://dev.clojure.org/jira/browse/CLJS-1461> needs to
be resolved.
Here's what to do.
1. Look over the tools.analyzer.js AST format
<http://clojure.github.io/tools.analyzer.js/spec/quickref.html>
2. Notice how the implementation of tools.analyzer.js conforms to this spec.
eg. case*
<https://github.com/clojure/tools.analyzer.js/blob/eec5e3dd3fbeb306511aa8cdbeb663bac94392f9/src/main/clojure/clojure/tools/analyzer/js.clj#L290-L325>,
or delegates to tools.analyzer, eg. try
<https://github.com/clojure/tools.analyzer/blob/f5d959f4e9e12a0a9d3d74293d9ff2ca0ad65ad4/src/main/clojure/clojure/tools/analyzer.clj#L373-L404>
3. Compare this spec to the actual ClojureScript analyzer.
eg. try
<https://github.com/clojure/clojurescript/blob/master/src/main/clojure/cljs/analyzer.cljc#L1000-L1059>
4. Note any differences between the specs.
eg. :catch in ClojureScript
<https://github.com/clojure/clojurescript/blob/3e1af212e114a9968c6f69719b0346df12bd6d0e/src/main/clojure/cljs/analyzer.cljc#L1058> :try
node, vs :catches vector in tools.analyzer
<https://github.com/clojure/tools.analyzer/blob/1c8693b30e8459ad3fbdb21871164ba82afb7b43/src/main/clojure/clojure/tools/analyzer.clj#L400>
:try node.
5. Prepare a patch for the ClojureScript analyzer that updates the
AST to conform to tools.analyzer.
I'm available to video chat over the week if that helps.
Thanks,
Ambrose

Post by Vincent Heuken
I recently made an issue on the typed clojurescript sample project's github
<https://github.com/frenchy64/typed-clojurescript-play/issues/1> regarding
core.typed not working on the latest version of Clojurescript. You
mentioned you had a list of things to get it working again. I'd love to try
and help get it working again.

--
Vincent Heuken

Ambrose Bonnaire-Sergeant

2016-01-31 01:40:34 UTC

Permalink

Looks good!

One strategy that helps is to evaluate a tools.analyzer.jvm AST and inspect
the output.

Thanks,
Ambrose

Post by Sean Walker
I have tried adjusting a few more forms to match the tools.analyzer ast,
and I want to make sure I'm on the right track as well. The commit is here
<https://github.com/AnOctopus/clojurescript/commit/07e553bd54945238c819795c4164a9f65d0ca23f>.
I'm not sure about a few things (is ctor just class, or something else?),
but I think I'm starting to understand how this part of the analyzer works.

Post by Sean Walker
Sure, my github is https://github.com/AnOctopus. I'll likely start on it
later this week, once I've cleared a few other things off of my plate.

Post by Ambrose Bonnaire-Sergeant
No progress from me either.
Sean, the instructions earlier in the thread should still be a good
starting point to work on.
Thanks,
Ambrose

Post by Vincent Heuken
Unfortunately I haven't had time. Feel free to start on it yourself if
you'd like.

Post by Sean Walker
Has any progress been made on this? I am interested in helping get
this updated, so I'm willing to assist/collaborate if you're still working
on this, or look into it myself otherwise.

Post by Vincent Heuken
Thanks for getting back to me.
I won't have time to start for a couple of days, but I wanted to go
in and try something simple to make sure I have the right idea, so I tried
my hand at throw
<http://clojure.github.io/tools.analyzer.js/spec/quickref.html#throw>. The
diff is below. Let me know if this is right or of I'm way off.
---
diff --git a/src/main/clojure/cljs/analyzer.cljc
b/src/main/clojure/cljs/analyzer.cljc
index 437c8a0..6eb5b6b 100644
--- a/src/main/clojure/cljs/analyzer.cljc
+++ b/src/main/clojure/cljs/analyzer.cljc
@@ -994,8 +994,8 @@
[op env [_ throw :as form] name _]
(let [throw-expr (disallowing-recur (analyze (assoc env :context
:expr) throw))]
{:env env :op :throw :form form
- :throw throw-expr
- :children [throw-expr]}))
+ :exception throw-expr
+ :children [:exception]}))
(defmethod parse 'try
[op env [_ & body :as form] name _]
On Sunday, November 29, 2015 at 2:53:46 PM UTC-8, Ambrose

Post by Ambrose Bonnaire-Sergeant
Hi Vincent,
Awesome!
This issue <http://dev.clojure.org/jira/browse/CLJS-1461> needs to
be resolved.
Here's what to do.
1. Look over the tools.analyzer.js AST format
<http://clojure.github.io/tools.analyzer.js/spec/quickref.html>
2. Notice how the implementation of tools.analyzer.js conforms to this spec.
eg. case*
<https://github.com/clojure/tools.analyzer.js/blob/eec5e3dd3fbeb306511aa8cdbeb663bac94392f9/src/main/clojure/clojure/tools/analyzer/js.clj#L290-L325>,
or delegates to tools.analyzer, eg. try
<https://github.com/clojure/tools.analyzer/blob/f5d959f4e9e12a0a9d3d74293d9ff2ca0ad65ad4/src/main/clojure/clojure/tools/analyzer.clj#L373-L404>
3. Compare this spec to the actual ClojureScript analyzer.
eg. try
<https://github.com/clojure/clojurescript/blob/master/src/main/clojure/cljs/analyzer.cljc#L1000-L1059>
4. Note any differences between the specs.
eg. :catch in ClojureScript
<https://github.com/clojure/clojurescript/blob/3e1af212e114a9968c6f69719b0346df12bd6d0e/src/main/clojure/cljs/analyzer.cljc#L1058> :try
node, vs :catches vector in tools.analyzer
<https://github.com/clojure/tools.analyzer/blob/1c8693b30e8459ad3fbdb21871164ba82afb7b43/src/main/clojure/clojure/tools/analyzer.clj#L400>
:try node.
5. Prepare a patch for the ClojureScript analyzer that updates the
AST to conform to tools.analyzer.
I'm available to video chat over the week if that helps.
Thanks,
Ambrose

Post by Vincent Heuken
I recently made an issue on the typed clojurescript sample project's github
<https://github.com/frenchy64/typed-clojurescript-play/issues/1> regarding
core.typed not working on the latest version of Clojurescript. You
mentioned you had a list of things to get it working again. I'd love to try
and help get it working again.

--
Vincent Heuken

Sean Walker

2016-01-31 06:14:20 UTC

Permalink

Yeah, a repl is proving useful (I'd been without it due to temporary issues
with cider). It looks like the clojurescript analyzer is generating the
constructor node, rather than a class node. It shouldn't be too hard to
convert it to the right form.

On Sat, Jan 30, 2016 at 5:40 PM, Ambrose Bonnaire-Sergeant <

Post by Ambrose Bonnaire-Sergeant
Looks good!
One strategy that helps is to evaluate a tools.analyzer.jvm AST and
inspect the output.
Thanks,
Ambrose

Post by Sean Walker
Sure, my github is https://github.com/AnOctopus. I'll likely start on
it later this week, once I've cleared a few other things off of my plate.

Post by Ambrose Bonnaire-Sergeant
No progress from me either.
Sean, the instructions earlier in the thread should still be a good
starting point to work on.
Thanks,
Ambrose

Post by Vincent Heuken
Unfortunately I haven't had time. Feel free to start on it yourself
if you'd like.

Post by Sean Walker
Has any progress been made on this? I am interested in helping get
this updated, so I'm willing to assist/collaborate if you're still working
on this, or look into it myself otherwise.

Post by Vincent Heuken
Thanks for getting back to me.
I won't have time to start for a couple of days, but I wanted to go
in and try something simple to make sure I have the right idea, so I tried
my hand at throw
<http://clojure.github.io/tools.analyzer.js/spec/quickref.html#throw>. The
diff is below. Let me know if this is right or of I'm way off.
---
diff --git a/src/main/clojure/cljs/analyzer.cljc
b/src/main/clojure/cljs/analyzer.cljc
index 437c8a0..6eb5b6b 100644
--- a/src/main/clojure/cljs/analyzer.cljc
+++ b/src/main/clojure/cljs/analyzer.cljc
@@ -994,8 +994,8 @@
[op env [_ throw :as form] name _]
(let [throw-expr (disallowing-recur (analyze (assoc env :context
:expr) throw))]
{:env env :op :throw :form form
- :throw throw-expr
- :children [throw-expr]}))
+ :exception throw-expr
+ :children [:exception]}))
(defmethod parse 'try
[op env [_ & body :as form] name _]
On Sunday, November 29, 2015 at 2:53:46 PM UTC-8, Ambrose

Post by Ambrose Bonnaire-Sergeant
Hi Vincent,
Awesome!
This issue <http://dev.clojure.org/jira/browse/CLJS-1461> needs
to be resolved.
Here's what to do.
1. Look over the tools.analyzer.js AST format
<http://clojure.github.io/tools.analyzer.js/spec/quickref.html>
2. Notice how the implementation of tools.analyzer.js conforms to
this spec.
eg. case*
<https://github.com/clojure/tools.analyzer.js/blob/eec5e3dd3fbeb306511aa8cdbeb663bac94392f9/src/main/clojure/clojure/tools/analyzer/js.clj#L290-L325>,
or delegates to tools.analyzer, eg. try
<https://github.com/clojure/tools.analyzer/blob/f5d959f4e9e12a0a9d3d74293d9ff2ca0ad65ad4/src/main/clojure/clojure/tools/analyzer.clj#L373-L404>
3. Compare this spec to the actual ClojureScript analyzer.
eg. try
<https://github.com/clojure/clojurescript/blob/master/src/main/clojure/cljs/analyzer.cljc#L1000-L1059>
4. Note any differences between the specs.
eg. :catch in ClojureScript
<https://github.com/clojure/clojurescript/blob/3e1af212e114a9968c6f69719b0346df12bd6d0e/src/main/clojure/cljs/analyzer.cljc#L1058> :try
node, vs :catches vector in tools.analyzer
<https://github.com/clojure/tools.analyzer/blob/1c8693b30e8459ad3fbdb21871164ba82afb7b43/src/main/clojure/clojure/tools/analyzer.clj#L400>
:try node.
5. Prepare a patch for the ClojureScript analyzer that updates the
AST to conform to tools.analyzer.
I'm available to video chat over the week if that helps.
Thanks,
Ambrose

Post by Vincent Heuken
I recently made an issue on the typed clojurescript sample
project's github
<https://github.com/frenchy64/typed-clojurescript-play/issues/1> regarding
core.typed not working on the latest version of Clojurescript. You
mentioned you had a list of things to get it working again. I'd love to try
and help get it working again.

--
Vincent Heuken

Sean Walker

2016-02-08 04:54:10 UTC

Permalink

Is there some way to get a a copy of my repl environment (or something else
easy to set up) as an :env value? I'd like to poke at var a bit, but since
it needs the var to exist, and the only premade environment seems to be the
empty one, I'm stuck using do and pulling it out of that.

Post by Sean Walker
Yeah, a repl is proving useful (I'd been without it due to temporary
issues with cider). It looks like the clojurescript analyzer is generating
the constructor node, rather than a class node. It shouldn't be too hard to
convert it to the right form.
On Sat, Jan 30, 2016 at 5:40 PM, Ambrose Bonnaire-Sergeant <

Post by Ambrose Bonnaire-Sergeant
Looks good!
One strategy that helps is to evaluate a tools.analyzer.jvm AST and
inspect the output.
Thanks,
Ambrose

Post by Sean Walker
Sure, my github is https://github.com/AnOctopus. I'll likely start on
it later this week, once I've cleared a few other things off of my plate.

Post by Ambrose Bonnaire-Sergeant
No progress from me either.
Sean, the instructions earlier in the thread should still be a good
starting point to work on.
Thanks,
Ambrose

Post by Vincent Heuken
Unfortunately I haven't had time. Feel free to start on it yourself
if you'd like.

Post by Sean Walker
Has any progress been made on this? I am interested in helping get
this updated, so I'm willing to assist/collaborate if you're still working
on this, or look into it myself otherwise.

Post by Vincent Heuken
Thanks for getting back to me.
I won't have time to start for a couple of days, but I wanted to
go in and try something simple to make sure I have the right idea, so I
tried my hand at throw
<http://clojure.github.io/tools.analyzer.js/spec/quickref.html#throw>. The
diff is below. Let me know if this is right or of I'm way off.
---
diff --git a/src/main/clojure/cljs/analyzer.cljc
b/src/main/clojure/cljs/analyzer.cljc
index 437c8a0..6eb5b6b 100644
--- a/src/main/clojure/cljs/analyzer.cljc
+++ b/src/main/clojure/cljs/analyzer.cljc
@@ -994,8 +994,8 @@
[op env [_ throw :as form] name _]
(let [throw-expr (disallowing-recur (analyze (assoc env
:context :expr) throw))]
{:env env :op :throw :form form
- :throw throw-expr
- :children [throw-expr]}))
+ :exception throw-expr
+ :children [:exception]}))
(defmethod parse 'try
[op env [_ & body :as form] name _]
On Sunday, November 29, 2015 at 2:53:46 PM UTC-8, Ambrose

Post by Ambrose Bonnaire-Sergeant
Hi Vincent,
Awesome!
This issue <http://dev.clojure.org/jira/browse/CLJS-1461> needs
to be resolved.
Here's what to do.
1. Look over the tools.analyzer.js AST format
<http://clojure.github.io/tools.analyzer.js/spec/quickref.html>
2. Notice how the implementation of tools.analyzer.js conforms to
this spec.
eg. case*
<https://github.com/clojure/tools.analyzer.js/blob/eec5e3dd3fbeb306511aa8cdbeb663bac94392f9/src/main/clojure/clojure/tools/analyzer/js.clj#L290-L325>,
or delegates to tools.analyzer, eg. try
<https://github.com/clojure/tools.analyzer/blob/f5d959f4e9e12a0a9d3d74293d9ff2ca0ad65ad4/src/main/clojure/clojure/tools/analyzer.clj#L373-L404>
3. Compare this spec to the actual ClojureScript analyzer.
eg. try
<https://github.com/clojure/clojurescript/blob/master/src/main/clojure/cljs/analyzer.cljc#L1000-L1059>
4. Note any differences between the specs.
eg. :catch in ClojureScript
<https://github.com/clojure/clojurescript/blob/3e1af212e114a9968c6f69719b0346df12bd6d0e/src/main/clojure/cljs/analyzer.cljc#L1058> :try
node, vs :catches vector in tools.analyzer
<https://github.com/clojure/tools.analyzer/blob/1c8693b30e8459ad3fbdb21871164ba82afb7b43/src/main/clojure/clojure/tools/analyzer.clj#L400>
:try node.
5. Prepare a patch for the ClojureScript analyzer that updates
the AST to conform to tools.analyzer.
I'm available to video chat over the week if that helps.
Thanks,
Ambrose

Post by Vincent Heuken
I recently made an issue on the typed clojurescript sample
project's github
<https://github.com/frenchy64/typed-clojurescript-play/issues/1> regarding
core.typed not working on the latest version of Clojurescript. You
mentioned you had a list of things to get it working again. I'd love to try
and help get it working again.

--
Vincent Heuken

Ambrose Bonnaire-Sergeant

2016-02-08 07:07:17 UTC

Permalink

I believe cljs.env contains the state of a REPL environment. That might be
a good place to start looking.

Thanks,
Ambrose

Post by Sean Walker
Is there some way to get a a copy of my repl environment (or something
else easy to set up) as an :env value? I'd like to poke at var a bit, but
since it needs the var to exist, and the only premade environment seems to
be the empty one, I'm stuck using do and pulling it out of that.
On Sat, Jan 30, 2016 at 10:14 PM, Sean Walker <

Post by Ambrose Bonnaire-Sergeant
Looks good!
One strategy that helps is to evaluate a tools.analyzer.jvm AST and
inspect the output.
Thanks,
Ambrose

Post by Sean Walker
I have tried adjusting a few more forms to match the tools.analyzer
ast, and I want to make sure I'm on the right track as well. The commit is
here
<https://github.com/AnOctopus/clojurescript/commit/07e553bd54945238c819795c4164a9f65d0ca23f>.
I'm not sure about a few things (is ctor just class, or something else?),
but I think I'm starting to understand how this part of the analyzer works.

Post by Sean Walker
Sure, my github is https://github.com/AnOctopus. I'll likely start on
it later this week, once I've cleared a few other things off of my plate.

Post by Ambrose Bonnaire-Sergeant
No progress from me either.
Sean, the instructions earlier in the thread should still be a good
starting point to work on.
Thanks,
Ambrose

Post by Vincent Heuken
Unfortunately I haven't had time. Feel free to start on it yourself
if you'd like.
On Fri, Jan 22, 2016 at 8:05 AM, Sean Walker <

Post by Sean Walker
Has any progress been made on this? I am interested in helping get
this updated, so I'm willing to assist/collaborate if you're still working
on this, or look into it myself otherwise.

Post by Vincent Heuken
Thanks for getting back to me.
I won't have time to start for a couple of days, but I wanted to
go in and try something simple to make sure I have the right idea, so I
tried my hand at throw
<http://clojure.github.io/tools.analyzer.js/spec/quickref.html#throw>. The
diff is below. Let me know if this is right or of I'm way off.
---
diff --git a/src/main/clojure/cljs/analyzer.cljc
b/src/main/clojure/cljs/analyzer.cljc
index 437c8a0..6eb5b6b 100644
--- a/src/main/clojure/cljs/analyzer.cljc
+++ b/src/main/clojure/cljs/analyzer.cljc
@@ -994,8 +994,8 @@
[op env [_ throw :as form] name _]
(let [throw-expr (disallowing-recur (analyze (assoc env
:context :expr) throw))]
{:env env :op :throw :form form
- :throw throw-expr
- :children [throw-expr]}))
+ :exception throw-expr
+ :children [:exception]}))
(defmethod parse 'try
[op env [_ & body :as form] name _]
On Sunday, November 29, 2015 at 2:53:46 PM UTC-8, Ambrose

Post by Ambrose Bonnaire-Sergeant
Hi Vincent,
Awesome!
This issue <http://dev.clojure.org/jira/browse/CLJS-1461> needs
to be resolved.
Here's what to do.
1. Look over the tools.analyzer.js AST format
<http://clojure.github.io/tools.analyzer.js/spec/quickref.html>
2. Notice how the implementation of tools.analyzer.js conforms
to this spec.
eg. case*
<https://github.com/clojure/tools.analyzer.js/blob/eec5e3dd3fbeb306511aa8cdbeb663bac94392f9/src/main/clojure/clojure/tools/analyzer/js.clj#L290-L325>,
or delegates to tools.analyzer, eg. try
<https://github.com/clojure/tools.analyzer/blob/f5d959f4e9e12a0a9d3d74293d9ff2ca0ad65ad4/src/main/clojure/clojure/tools/analyzer.clj#L373-L404>
3. Compare this spec to the actual ClojureScript analyzer.
eg. try
<https://github.com/clojure/clojurescript/blob/master/src/main/clojure/cljs/analyzer.cljc#L1000-L1059>
4. Note any differences between the specs.
eg. :catch in ClojureScript
<https://github.com/clojure/clojurescript/blob/3e1af212e114a9968c6f69719b0346df12bd6d0e/src/main/clojure/cljs/analyzer.cljc#L1058> :try
node, vs :catches vector in tools.analyzer
<https://github.com/clojure/tools.analyzer/blob/1c8693b30e8459ad3fbdb21871164ba82afb7b43/src/main/clojure/clojure/tools/analyzer.clj#L400>
:try node.
5. Prepare a patch for the ClojureScript analyzer that updates
the AST to conform to tools.analyzer.
I'm available to video chat over the week if that helps.
Thanks,
Ambrose
On Sun, Nov 29, 2015 at 4:55 PM, Vincent Heuken <

Post by Vincent Heuken
I recently made an issue on the typed clojurescript sample
project's github
<https://github.com/frenchy64/typed-clojurescript-play/issues/1> regarding
core.typed not working on the latest version of Clojurescript. You
mentioned you had a list of things to get it working again. I'd love to try
and help get it working again.

--
Vincent Heuken

Sean Walker

2016-02-09 01:48:18 UTC

Permalink

cljs.env didn't have quite what I was looking for. Calling
(default-compiler-env) in the repl causes it to hang, and at this point
it's going to be easier to either construct a minimal environment by hand
or just stick to extracting info from analyzing a do form.

On Sun, Feb 7, 2016 at 11:07 PM, Ambrose Bonnaire-Sergeant <

Post by Ambrose Bonnaire-Sergeant
I believe cljs.env contains the state of a REPL environment. That might be
a good place to start looking.
Thanks,
Ambrose

Post by Ambrose Bonnaire-Sergeant
Looks good!
One strategy that helps is to evaluate a tools.analyzer.jvm AST and
inspect the output.
Thanks,
Ambrose

Post by Sean Walker
I have tried adjusting a few more forms to match the tools.analyzer
ast, and I want to make sure I'm on the right track as well. The commit is
here
<https://github.com/AnOctopus/clojurescript/commit/07e553bd54945238c819795c4164a9f65d0ca23f>.
I'm not sure about a few things (is ctor just class, or something else?),
but I think I'm starting to understand how this part of the analyzer works.

Post by Sean Walker
Sure, my github is https://github.com/AnOctopus. I'll likely start
on it later this week, once I've cleared a few other things off of my plate.

Post by Ambrose Bonnaire-Sergeant
No progress from me either.
Sean, the instructions earlier in the thread should still be a good
starting point to work on.
Thanks,
Ambrose

Post by Vincent Heuken
Unfortunately I haven't had time. Feel free to start on it
yourself if you'd like.
On Fri, Jan 22, 2016 at 8:05 AM, Sean Walker <

Post by Sean Walker
Has any progress been made on this? I am interested in helping
get this updated, so I'm willing to assist/collaborate if you're still
working on this, or look into it myself otherwise.

Post by Vincent Heuken
Thanks for getting back to me.
I won't have time to start for a couple of days, but I wanted to
go in and try something simple to make sure I have the right idea, so I
tried my hand at throw
<http://clojure.github.io/tools.analyzer.js/spec/quickref.html#throw>. The
diff is below. Let me know if this is right or of I'm way off.
---
diff --git a/src/main/clojure/cljs/analyzer.cljc
b/src/main/clojure/cljs/analyzer.cljc
index 437c8a0..6eb5b6b 100644
--- a/src/main/clojure/cljs/analyzer.cljc
+++ b/src/main/clojure/cljs/analyzer.cljc
@@ -994,8 +994,8 @@
[op env [_ throw :as form] name _]
(let [throw-expr (disallowing-recur (analyze (assoc env
:context :expr) throw))]
{:env env :op :throw :form form
- :throw throw-expr
- :children [throw-expr]}))
+ :exception throw-expr
+ :children [:exception]}))
(defmethod parse 'try
[op env [_ & body :as form] name _]
On Sunday, November 29, 2015 at 2:53:46 PM UTC-8, Ambrose

Post by Ambrose Bonnaire-Sergeant
Hi Vincent,
Awesome!
This issue <http://dev.clojure.org/jira/browse/CLJS-1461>
needs to be resolved.
Here's what to do.
1. Look over the tools.analyzer.js AST format
<http://clojure.github.io/tools.analyzer.js/spec/quickref.html>
2. Notice how the implementation of tools.analyzer.js conforms
to this spec.
eg. case*
<https://github.com/clojure/tools.analyzer.js/blob/eec5e3dd3fbeb306511aa8cdbeb663bac94392f9/src/main/clojure/clojure/tools/analyzer/js.clj#L290-L325>,
or delegates to tools.analyzer, eg. try
<https://github.com/clojure/tools.analyzer/blob/f5d959f4e9e12a0a9d3d74293d9ff2ca0ad65ad4/src/main/clojure/clojure/tools/analyzer.clj#L373-L404>
3. Compare this spec to the actual ClojureScript analyzer.
eg. try
<https://github.com/clojure/clojurescript/blob/master/src/main/clojure/cljs/analyzer.cljc#L1000-L1059>
4. Note any differences between the specs.
eg. :catch in ClojureScript
<https://github.com/clojure/clojurescript/blob/3e1af212e114a9968c6f69719b0346df12bd6d0e/src/main/clojure/cljs/analyzer.cljc#L1058> :try
node, vs :catches vector in tools.analyzer
<https://github.com/clojure/tools.analyzer/blob/1c8693b30e8459ad3fbdb21871164ba82afb7b43/src/main/clojure/clojure/tools/analyzer.clj#L400>
:try node.
5. Prepare a patch for the ClojureScript analyzer that updates
the AST to conform to tools.analyzer.
I'm available to video chat over the week if that helps.
Thanks,
Ambrose
On Sun, Nov 29, 2015 at 4:55 PM, Vincent Heuken <

Post by Vincent Heuken
I recently made an issue on the typed clojurescript sample
project's github
<https://github.com/frenchy64/typed-clojurescript-play/issues/1> regarding
core.typed not working on the latest version of Clojurescript. You
mentioned you had a list of things to get it working again. I'd love to try
and help get it working again.

--
Vincent Heuken

Sean Walker

2016-03-11 00:56:41 UTC

Permalink

It's been about a month since my last update, so I thought I would share
the progress since then. It's not much, mostly analysis, because I've
been rather busy with interviews and other related job stuff.

I've determined that the quote form will need to be created from
scratch, because tools.analyzer has an actual quote node and cljs just
sets a flag in the environment. It's not particularly complicated of a
form, though.

Let, loop, and recur are a bit messy, because loop and let are the same
form with some extra info (loop target) stored for loop. It looks like
the :info map contains the same info as the parent node, so it should
maybe be changed the way :children has been. (I only seem to have one,
unlabeled ast form for loop in my notes, so I'll have to see what
changes need to happen.)

Post by Sean Walker
cljs.env didn't have quite what I was looking for. Calling
(default-compiler-env) in the repl causes it to hang, and at this point
it's going to be easier to either construct a minimal environment by hand
or just stick to extracting info from analyzing a do form.
On Sun, Feb 7, 2016 at 11:07 PM, Ambrose Bonnaire-Sergeant <

Post by Ambrose Bonnaire-Sergeant
I believe cljs.env contains the state of a REPL environment. That might be
a good place to start looking.
Thanks,
Ambrose

Post by Ambrose Bonnaire-Sergeant
Looks good!
One strategy that helps is to evaluate a tools.analyzer.jvm AST and
inspect the output.
Thanks,
Ambrose

Post by Sean Walker
I have tried adjusting a few more forms to match the tools.analyzer
ast, and I want to make sure I'm on the right track as well. The commit is
here
<https://github.com/AnOctopus/clojurescript/commit/07e553bd54945238c819795c4164a9f65d0ca23f>.
I'm not sure about a few things (is ctor just class, or something else?),
but I think I'm starting to understand how this part of the analyzer works.

Post by Sean Walker
Sure, my github is https://github.com/AnOctopus. I'll likely start
on it later this week, once I've cleared a few other things off of my plate.

Post by Ambrose Bonnaire-Sergeant
No progress from me either.
Sean, the instructions earlier in the thread should still be a good
starting point to work on.
Thanks,
Ambrose

Post by Vincent Heuken
Unfortunately I haven't had time. Feel free to start on it
yourself if you'd like.
On Fri, Jan 22, 2016 at 8:05 AM, Sean Walker <

Post by Sean Walker
Has any progress been made on this? I am interested in helping
get this updated, so I'm willing to assist/collaborate if you're still
working on this, or look into it myself otherwise.
On Monday, November 30, 2015 at 12:06:27 AM UTC-8, Vincent Heuken

Post by Vincent Heuken
Thanks for getting back to me.
I won't have time to start for a couple of days, but I wanted to
go in and try something simple to make sure I have the right idea, so I
tried my hand at throw
<http://clojure.github.io/tools.analyzer.js/spec/quickref.html#throw>. The
diff is below. Let me know if this is right or of I'm way off.
---
diff --git a/src/main/clojure/cljs/analyzer.cljc
b/src/main/clojure/cljs/analyzer.cljc
index 437c8a0..6eb5b6b 100644
--- a/src/main/clojure/cljs/analyzer.cljc
+++ b/src/main/clojure/cljs/analyzer.cljc
@@ -994,8 +994,8 @@
[op env [_ throw :as form] name _]
(let [throw-expr (disallowing-recur (analyze (assoc env
:context :expr) throw))]
{:env env :op :throw :form form
- :throw throw-expr
- :children [throw-expr]}))
+ :exception throw-expr
+ :children [:exception]}))
(defmethod parse 'try
[op env [_ & body :as form] name _]
On Sunday, November 29, 2015 at 2:53:46 PM UTC-8, Ambrose

Post by Ambrose Bonnaire-Sergeant
Hi Vincent,
Awesome!
This issue <http://dev.clojure.org/jira/browse/CLJS-1461>
needs to be resolved.
Here's what to do.
1. Look over the tools.analyzer.js AST format
<http://clojure.github.io/tools.analyzer.js/spec/quickref.html>
2. Notice how the implementation of tools.analyzer.js conforms
to this spec.
eg. case*
<https://github.com/clojure/tools.analyzer.js/blob/eec5e3dd3fbeb306511aa8cdbeb663bac94392f9/src/main/clojure/clojure/tools/analyzer/js.clj#L290-L325>,
or delegates to tools.analyzer, eg. try
<https://github.com/clojure/tools.analyzer/blob/f5d959f4e9e12a0a9d3d74293d9ff2ca0ad65ad4/src/main/clojure/clojure/tools/analyzer.clj#L373-L404>
3. Compare this spec to the actual ClojureScript analyzer.
eg. try
<https://github.com/clojure/clojurescript/blob/master/src/main/clojure/cljs/analyzer.cljc#L1000-L1059>
4. Note any differences between the specs.
eg. :catch in ClojureScript
<https://github.com/clojure/clojurescript/blob/3e1af212e114a9968c6f69719b0346df12bd6d0e/src/main/clojure/cljs/analyzer.cljc#L1058> :try
node, vs :catches vector in tools.analyzer
<https://github.com/clojure/tools.analyzer/blob/1c8693b30e8459ad3fbdb21871164ba82afb7b43/src/main/clojure/clojure/tools/analyzer.clj#L400>
:try node.
5. Prepare a patch for the ClojureScript analyzer that updates
the AST to conform to tools.analyzer.
I'm available to video chat over the week if that helps.
Thanks,
Ambrose
On Sun, Nov 29, 2015 at 4:55 PM, Vincent Heuken <

Post by Vincent Heuken
I recently made an issue on the typed clojurescript sample
project's github
<https://github.com/frenchy64/typed-clojurescript-play/issues/1> regarding
core.typed not working on the latest version of Clojurescript. You
mentioned you had a list of things to get it working again. I'd love to try
and help get it working again.

--
Vincent Heuken

Ambrose Bonnaire-Sergeant

2016-03-11 02:11:26 UTC

Permalink

Awesome!

Post by Sean Walker
It's been about a month since my last update, so I thought I would share
the progress since then. It's not much, mostly analysis, because I've
been rather busy with interviews and other related job stuff.
I've determined that the quote form will need to be created from
scratch, because tools.analyzer has an actual quote node and cljs just
sets a flag in the environment. It's not particularly complicated of a
form, though.
Let, loop, and recur are a bit messy, because loop and let are the same
form with some extra info (loop target) stored for loop. It looks like
the :info map contains the same info as the parent node, so it should
maybe be changed the way :children has been. (I only seem to have one,
unlabeled ast form for loop in my notes, so I'll have to see what
changes need to happen.)

Post by Ambrose Bonnaire-Sergeant
I believe cljs.env contains the state of a REPL environment. That might